JSON-RPC password

Bitcointalk · 2010-07-18 20:49:22 UTC

AuthorSatoshi Nakamoto

TitleJSON-RPC password

Date2010-07-18 20:49:22 UTC

ForumBitcointalk · 原文

我把给 JSON-RPC 加密码的改动上传到了 SVN。如果你能自己构建，请帮忙测试。

-server 开关被 -rpcpw=<password> 取代了，bitcoind 也用它。
bitcoin -rpcpw=<password> -- 以 JSON-RPC 端口开放的方式运行
bitcoind -rpcpw=<password> -- 带密码的守护进程

如果你对开关名有更好的想法，告诉我，但记住以后数据库加密也会有个密码。我不确定，但我觉得它们可能想用两个不同的密码。

如果你不设密码，它会给出警告。

现在所有命令都要求密码作为第一个参数。如果你运行 "bitcoind help" 它会告诉你。

核心代码：

// Check password
if (params.size() < 1 || params[0].type() != str_type)
throw runtime_error("First parameter must be the password.");
if (params[0].get_str() != strRPCPassword)
{
if (strRPCPassword.size() < 15)
Sleep(50);
begin = strRequest.end();
printf("ThreadRPCServer incorrect password attempt\n");
throw runtime_error("Incorrect password.");
}

对这些决定有什么评论吗？

1) if (strRPCPassword.size() < 15) Sleep(50); -- 意思是如果密码很短，每次尝试后会等 50ms。这可能被用作 DoS 攻击，但我想如果密码很短，防范暴力密码扫描更重要。这可能会让外界知道密码是否少于 15 个字符，但少于 15 也没什么大不了，大多数密码都少于 15。如果你想堵住 DoS 的可能，就用 15 个字符或更长的密码。

2) begin = strRequest.end(); -- 如果一次请求里有多次调用，其中一次密码错了我就把剩下的全扔掉。这样你就没法在一个包里塞几百万次密码尝试。你觉得这样做对吗？（多次调用反正几乎没人用）

我还修了帮助里列出的两个重复命令：

getaddressesbylabel <pw> <label>
getbalance <pw>
getblockcount <pw>
getblocknumber <pw>
getconnectioncount <pw>
getdifficulty <pw>
getgenerate <pw>
getinfo <pw>
getlabel <pw> <bitcoinaddress>
getnewaddress <pw> [label]
getreceivedbyaddress <pw> <bitcoinaddress> [minconf=1]
getreceivedbylabel <pw> <label> [minconf=1]
help <pw>
listreceivedbyaddress <pw> [minconf=1] [includeempty=false]
listreceivedbylabel <pw> [minconf=1] [includeempty=false]
sendtoaddress <pw> <bitcoinaddress> <amount> [comment] [comment-to]
setgenerate <pw> <generate> [genproclimit]
setlabel <pw> <bitcoinaddress> <label>
stop <pw>

英文原文

I uploaded to SVN my changes to add a password to JSON-RPC. If you're set up to build, please test it.

The -server switch is replaced with -rpcpw=<password>, which is also used with bitcoind.
bitcoin -rpcpw=<password> -- runs with JSON-RPC port open
bitcoind -rpcpw=<password> -- daemon with password

If you have a better idea for the switch name, let me know, but keep in mind there will eventually be a password for encrypting the database too. I'm not sure but I think they may want to use different passwords for the two.

It gives a warning if you don't set a password.

All commands now require the password as the first parameter. It'll tell you that if you run "bitcoind help".

The central code:

Any comments on these decisions?

1) if (strRPCPassword.size() < 15) Sleep(50); -- this means if it's a short password, it'll wait 50ms after each attempt. This might be used as a DoS attack, but I figured if it's a short password, it's more important to protect against brute force password scan. This may tell outsiders whether the password is less than 15 characters, but less than 15 isn't all that noteworthy, most passwords are less than 15. If you want to close the DoS possibility, just use a password 15 characters or longer.

2) begin = strRequest.end(); -- if it's a single request with multiple invocations, I throw away the rest if one has a bad password. This is so you can't stuff it with millions of password attempts in one packet. What do you think, is this the right thing to do? (multiple invocation is probably almost never used anyway)

I also fixed the two duplicated commands listed in the help: